feat: update registry coordinator for new createOperatorSets
#544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ypatil12
force-pushed
the
feat/update-regCoord-createOpSets
branch
from
1fbeb57 to
b31bebd
Compare
Update readme for new table calcs deployed fix: compile fix: tests fix: ci pin version fix: pin forge test: add skips chore: fmt
ypatil12
force-pushed
the
feat/update-regCoord-createOpSets
branch
from
b31bebd to
2b08af7
Compare
Collaborator
Author
|
Note: storage layout appears to be flaky here. No difference between the two and there were no changes to storage of the |
|
|
||
| /// @notice For delegated stake quorums, the address that is set to slash | ||
| /// @dev This address is set to the burn address as 0 addresses are not valid slasher addresses | ||
| address public constant DELEGATED_STAKE_SLASHER = 0x00000000000000000000000000000000000E16E4; |
| address(registryCoordinator), | ||
| allocationManagerAddr, | ||
| IAllocationManager.createOperatorSets.selector | ||
| bytes4(keccak256("createOperatorSets(address,(uint32,address[],address)[])")) |
Member
There was a problem hiding this comment.
Guessing this is because there's now two createOperatorSets aliases?
Comment on lines
234
to
236
| AllocationManagerView allocationManagerView = new AllocationManagerView( | ||
| delegationManager, eigenStrategy, uint32(7 days), uint32(1 days) | ||
| ); |
Member
There was a problem hiding this comment.
Named parameters preferred for readability.
test/utils/MockAVSDeployer.sol
Outdated
| ); | ||
|
|
||
| allocationManagerView = | ||
| new AllocationManagerView(delegationMock, eigenStrategy, uint32(7 days), uint32(1 days)); |
| ] | ||
| # Specifies the exact version of Solidity to use, overriding auto-detection. | ||
| solc_version = '0.8.27' | ||
| solc_version = '0.8.29' |
Member
There was a problem hiding this comment.
Maybe want to double check pragmas, especially for ALM view (must be >=0.8.29).
Collaborator
Author
There was a problem hiding this comment.
Pragmas should be fine since they don't need to be 0.8.29, only ALM, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
As part of Layr-Labs/eigenlayer-contracts#1645, we are adding a new
createOperatorSetsfunction that passes in the slasher address upon creation of an operatorSet. Although the oldcreateOperatorSetsfunction is not being deprecated, we are updating theRegistryCoordinatorin order to be only compatible the new function.Modifications:
createSlashableStakeQuorumto take in aslasheraddresssolcversion infoundry.tomlto0.8.29, matching CoreResult:
Compatible with updated
AllocationManagerinterface